Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set the corruption field #2487

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Always set the corruption field #2487

merged 1 commit into from
Feb 24, 2025

Conversation

FloSch62
Copy link
Member

I do not see any reason why the setCorruption was untouched when >0
That also meant, a set to 0 was not possible

@hellt hellt merged commit e069a73 into main Feb 24, 2025
66 of 67 checks passed
@hellt hellt deleted the netem_corruption branch February 24, 2025 09:06
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.43%. Comparing base (1c9c561) to head (63396f6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2487      +/-   ##
==========================================
- Coverage   52.48%   52.43%   -0.06%     
==========================================
  Files         172      172              
  Lines       17692    17692              
==========================================
- Hits         9285     9276       -9     
- Misses       7433     7439       +6     
- Partials      974      977       +3     
Files with missing lines Coverage Δ
internal/tc/tc.go 72.52% <100.00%> (ø)

... and 2 files with indirect coverage changes

@hellt
Copy link
Member

hellt commented Feb 24, 2025

thnx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants