Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image inputs in announce #29

Merged
merged 5 commits into from
Jan 19, 2024
Merged

Add image inputs in announce #29

merged 5 commits into from
Jan 19, 2024

Conversation

SachinPrasanth777
Copy link
Member

Description

Created a new field in modal for adding image inputs for announcements.

Fixes #28

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

src/commands/announce.ts Outdated Show resolved Hide resolved
src/events/handleModal.ts Outdated Show resolved Hide resolved
src/events/handleModal.ts Outdated Show resolved Hide resolved
@alvinbengeorge
Copy link
Member

LGTM 🚀🚀

@@ -3,6 +3,25 @@ import { COLOR, FOOTER_VALUE } from "../config/constant";
import db from "../utils/database";
import { TemplateSchemaType } from "../types";

async function isValidImageUrl(url: string): Promise<boolean> {
try {
const response = await fetch(url, { method: "HEAD" });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

Copy link
Contributor

@shawshankkumar shawshankkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@alvinbengeorge alvinbengeorge merged commit 145af7f into main Jan 19, 2024
2 checks passed
@alvinbengeorge alvinbengeorge deleted the sp/feat/input-image branch January 19, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request review requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Take input for image field for announcement command
6 participants