Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor isMod #76

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Refactor isMod #76

merged 1 commit into from
Mar 10, 2024

Conversation

SachinPrasanth777
Copy link
Member

@SachinPrasanth777 SachinPrasanth777 commented Mar 9, 2024 •
edited
Loading

Description

Refactored the isMod condition.

Fixes #66

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@SachinPrasanth777 SachinPrasanth777 added the Chore Minor Non Breaking Change label Mar 9, 2024
@SachinPrasanth777 SachinPrasanth777 self-assigned this Mar 9, 2024
HarshPatel5940
HarshPatel5940 approved these changes Mar 9, 2024
View reviewed changes
Copy link
Member

@HarshPatel5940 HarshPatel5940 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

alvinbengeorge
alvinbengeorge approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@alvinbengeorge alvinbengeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @SachinPrasanth777, LGTM 🚀

@alvinbengeorge alvinbengeorge merged commit 81386d2 into main Mar 10, 2024
1 check passed
@alvinbengeorge alvinbengeorge deleted the sp/chore/refactor-mod branch March 10, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvinbengeorge alvinbengeorge alvinbengeorge approved these changes

@HarshPatel5940 HarshPatel5940 HarshPatel5940 approved these changes

@sm-sami sm-sami Awaiting requested review from sm-sami

Assignees

@SachinPrasanth777 SachinPrasanth777

Labels
Chore Minor Non Breaking Change Ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix isMod checks to be executed correctly
3 participants
@SachinPrasanth777 @alvinbengeorge @HarshPatel5940