Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checks for appropriate permission before editing #79

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Checks for appropriate permission before editing #79

merged 3 commits into from
Mar 14, 2024

Conversation

vijaybalamahalingam
Copy link
Collaborator

Description

Implemented appropriate permission checking.

Fixes #59

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@vijaybalamahalingam vijaybalamahalingam self-assigned this Mar 14, 2024
HarshPatel5940
HarshPatel5940 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@HarshPatel5940 HarshPatel5940 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@HarshPatel5940 HarshPatel5940 merged commit a6b042e into main Mar 14, 2024
1 check passed
@HarshPatel5940 HarshPatel5940 deleted the vb/refact/appropriate-perms branch March 14, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshPatel5940 HarshPatel5940 HarshPatel5940 approved these changes

Assignees

@vijaybalamahalingam vijaybalamahalingam

Labels
review requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(refact) check for appropriate perms before editing
2 participants
@vijaybalamahalingam @HarshPatel5940