Merge pull request #85 from srvanrell/fix-add-entry-temp-ranking

fix to add entry to empty temp ranking add coverage report
srvanrell · Aug 12, 2024 · 13be74e · 13be74e
2 parents 3bf1e78 + 259bac9
commit 13be74e
Show file tree

Hide file tree

Showing 4 changed files with 111 additions and 4 deletions.
diff --git a/.github/workflows/regression_tests.yml b/.github/workflows/regression_tests.yml
@@ -34,4 +34,4 @@ jobs:
       run: poetry install
 
     - name: Run tests
-      run: poetry run pytest -vvv
+      run: poetry run pytest -vvv --cov=ranking_table_tennis --cov-report=html --cov-report=term-missing
diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "ranking_table_tennis"
-version = "2024.8.11"
+version = "2024.8.12"
 description = "A ranking table tennis system"
 readme = "README.md"
 authors = [ "Sebastian Vanrell srvanrell_gmail_com" ]
@@ -39,6 +39,7 @@ pyclean = "3.*"
 pytest = "8.*"
 pytest-shell-utilities ="1.9.*"
 pytest_profiling = "1.7.*"
+pytest-cov = "^5.0.0"
 
 [tool.poetry.scripts]
 rtt = "ranking_table_tennis.command_line:main"

diff --git a/ranking_table_tennis/models/rankings.py b/ranking_table_tennis/models/rankings.py
@@ -84,7 +84,8 @@ def get_entries(self, tid: str, pid: int = None, col: str = None):
             return self.ranking_df.loc[entries_indexes]
 
     def add_entry(self, ranking_entry: pd.Series) -> None:
-        self.ranking_df = pd.concat([self.ranking_df, ranking_entry], axis="index")
+        ranking_entry_df = ranking_entry.to_frame().T
+        self.ranking_df = pd.concat([self.ranking_df, ranking_entry_df], axis="index")
         self.verify_and_normalize()
 
     def add_new_entry(