STAC 1.0.0-beta.1 support #116
Conversation
| @@ -13,10 +13,10 @@ object AssetCollectionExtension { | |||
|
|
|||
| implicit val encAssetCollectionExtension: Encoder.AsObject[AssetCollectionExtension] = Encoder | |||
| .AsObject[Map[String, Json]] | |||
| .contramapObject((extensionFields: AssetCollectionExtension) => Map("assets" -> extensionFields.assets.asJson)) | |||
| .contramapObject((extensionFields: AssetCollectionExtension) => Map("item_assets" -> extensionFields.assets.asJson)) | |||
There was a problem hiding this comment.
Change #1 assets => item_assets
| centerWavelength: Option[PosDouble], | ||
| fullWidthHalfMax: Option[PosDouble] |
There was a problem hiding this comment.
Change #2: wavelengths are Doubles
| @@ -8,7 +8,6 @@ import io.circe.syntax._ | |||
| import com.azavea.stac4s.extensions.ItemExtension | |||
|
|
|||
| case class EOItemExtension( | |||
| gsd: Double, | |||
There was a problem hiding this comment.
Change #3: gsd is no longer a part of the extension, it is a part of item.properties
| type Percentage = Int Refined Interval.Closed[W.`0`.T, W.`100`.T] | ||
| object Percentage extends RefinedTypeOps[Percentage, Int] | ||
|
|
||
| type BandRange = PosInt |
There was a problem hiding this comment.
Change #4: we don't need BadRange in assets anymore, it is a List[Band] now.
| import io.circe.syntax._ | ||
|
|
||
| case class EOAssetExtension( | ||
| bands: NonEmptyList[BandRange] | ||
| bands: NonEmptyList[Band] |
There was a problem hiding this comment.
Change #4 (2): we don't need BadRange in assets anymore, it is a List[Band] now.
pomadchin
force-pushed
the
feature/1.0.0-b1
branch
from
0f927cf to
095ce9a
Compare
|
This looks good to me. One follow up I think is that maybe we need to get rid of |
|
@notthatbreezy tbh I thought about it during this refactor. There is common metadata spec so we can at least cover extraction and validation of fields that are described here. Definitely sounds like a separate issue for me. |
|
@notthatbreezy @jisantuc I created an issue to discuss it so we won't loose it. |
Overview
This PR updates the codebase to support STAC 1.0
Checklist
Notes
This PR also updates the test catalog (wich was incredibly useful for testing purposes but took some time). I'll remove them in a follow up PR (anyway I had to update and validate them somehow to support the STAC Layer extension description) and it will be done in terms of https://github.com/azavea/geotrellis/issues/260 later this sprint.
Closes #114