[fix] missing const in arguments of RobotWrapper.set_rotor_inertia
and RobotWrapper.set_gear_ratios
python bindings
#245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds missing
const
identifier to the arguments of two methods ofRobotWrapper
:set_rotor_inertia
andset_gear_ratios
in python bingings. This problem practically disallowed to use motor inertia in python bindings.Right now, this functionality does not work, and an attempt to run the simplest example:
results in: