Use EOL data to curate the list of supported versions #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscar-izval
commented
Feb 1, 2024
Comment on lines
-106
to
-109
| # TODO: Combine the output of the following endpoints to get a list of active | ||
| # versions | ||
| # https://api.github.com/repos/hashicorp/terraform/tags | ||
| # https://endoflife.date/api/terraform.json |
There was a problem hiding this comment.
Not sure if I captured the whole idea presented here. In any case, using the tags endpoint could be problematic since we wouldn't be able to filter out draft tags.
sestrella
reviewed
Feb 1, 2024
sestrella
reviewed
Feb 1, 2024
Co-authored-by: Sebastian Estrella <2049686+sestrella@users.noreply.github.com>
|
Hey @sestrella! I just merged your suggestions and limited the scope of the PR, can you take another look please? |
sestrella
approved these changes
Feb 2, 2024
oscar-izval
added a commit
that referenced
this pull request
Feb 6, 2024
This reverts commit 733e252.
oscar-izval
added a commit
that referenced
this pull request
Feb 6, 2024
* Revert "Use EOL data to curate the list of supported versions (#29)" This reverts commit 733e252. * Revert "Add missing description" This reverts commit 3637dcd. * Revert "feat: Drop support for Terraform 1.5 versions (#26)" This reverts commit 869f7d3. * Add description back in * Support Terraform 1.4 * Update templates * Update supported range in readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.