Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding gclid support #37

Merged
merged 2 commits into from
Jan 27, 2025
Merged

feat: Adding gclid support #37

merged 2 commits into from
Jan 27, 2025

Conversation

JosueDiaz1722
Copy link
Contributor

Technical Details

We need to able to track the GCLID parameters that are being sent in the url.

Task List

  • Tests: integration.test.ts
  • Documentation update: Readme
  • Performance consideration: N/A
  • Security consideration: N/A

@JosueDiaz1722 JosueDiaz1722 marked this pull request as ready for review January 27, 2025 12:18
hakenprog
hakenprog approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@hakenprog hakenprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JosueDiaz1722 JosueDiaz1722 merged commit 5a72a2d into main Jan 27, 2025
2 checks passed
@JosueDiaz1722 JosueDiaz1722 deleted the feat/gclid-support branch January 27, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakenprog hakenprog hakenprog approved these changes

@sadjow sadjow Awaiting requested review from sadjow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JosueDiaz1722 @hakenprog