Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add self link and a create-order rel link to OpportunityCollection returned by the product_router #92

Closed
parksjr opened this issue Nov 1, 2024 · 2 comments
Assignees

Comments

@parksjr
Copy link
Contributor

parksjr commented Nov 1, 2024

See comment on pr #80 here: #80 (comment)

Also extend this for OrderCollection.
background: we are changing the get_orders endpoint to return an OrderCollection (like OpportunityCollection) instead of list[Order]
see comment on pr #80 here: #80 (comment)

@jkeifer
Copy link
Member

jkeifer commented Nov 4, 2024

I found #47 does address the OpportunityCollection link. I am not sure it can be rebased effectively at this point, but the code there might serve as an effective start at implementing that link.

@philvarner
Copy link
Contributor

I'm going to add the create-order link, but it's not conventional for a search endpoint like /opportunities to return a self link unless there's actually an identifiable persistent resource created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants