Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat subclass router issue 73 #80

Merged
merged 30 commits into from
Nov 1, 2024
Merged

Feat subclass router issue 73 #80

merged 30 commits into from
Nov 1, 2024

Conversation

austin-sidekick
Copy link
Contributor

No description provided.

jkeifer
jkeifer reviewed Oct 9, 2024
View reviewed changes
conftest.py Outdated Show resolved Hide resolved
CloudNiner
CloudNiner reviewed Oct 9, 2024
View reviewed changes
stapi_fastapi/__dev__.py Outdated Show resolved Hide resolved
jkeifer
jkeifer reviewed Oct 9, 2024
View reviewed changes
stapi_fastapi/__dev__.py Outdated Show resolved Hide resolved
jkeifer
jkeifer reviewed Oct 9, 2024
View reviewed changes
stapi_fastapi/__dev__.py Outdated Show resolved Hide resolved
c-wygoda
c-wygoda reviewed Oct 10, 2024
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
@parksjr
Copy link
Contributor

parksjr commented Oct 15, 2024

I am picking this up to see if we can help get it over the finish line

@parksjr parksjr self-assigned this Oct 15, 2024
@c-wygoda
Copy link
Member

hello, any way one can help out with this?

@jkeifer
Copy link
Member

jkeifer commented Oct 24, 2024

@c-wygoda: @parksjr is working on this pretty heavily right now. I will see if I can get him to ensure his code is pushed to a public branch and link it here; I don't think he's ready to merge what he has in with this one yet. I'm not sure if there's room for collaboration or not, but I can say we are aiming to have this work completed by mid next week.

parksjr and others added 2 commits October 30, 2024 17:43
@parksjr parksjr mentioned this pull request Nov 1, 2024
Closed
@parksjr @tylanderson @jkeifer
fixes StapiExceptions
375c51c 
Co-authored-by: Tyler <tylanderson@users.noreply.github.com>
Co-authored-by: Jarrett Keifer <jkeifer@users.noreply.github.com>
@parksjr @tylanderson @jkeifer
passes product router instead of product to backend
9355fdf 
Co-authored-by: Tyler <tylanderson@users.noreply.github.com>
Co-authored-by: Jarrett Keifer <jkeifer@users.noreply.github.com>
@parksjr @tylanderson @jkeifer
Adds OrderCollection type and returns for get_orders
f965f99 
Co-authored-by: Tyler <tylanderson@users.noreply.github.com>
Co-authored-by: Jarrett Keifer <jkeifer@users.noreply.github.com>
@parksjr parksjr linked an issue Nov 1, 2024 that may be closed by this pull request
Missing /products/{productId}/parameters endpoint #71
Closed
This was referenced Nov 1, 2024
Closed
Closed
@parksjr
Copy link
Contributor

parksjr commented Nov 1, 2024

Closes #73
Closes #71
Closes #81

@jkeifer jkeifer merged commit df6d1f0 into main Nov 1, 2024
3 checks passed
@jkeifer jkeifer deleted the feat-subclass-router-issue-73 branch November 1, 2024 23:49
This was referenced Nov 2, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-wygoda c-wygoda c-wygoda left review comments

@jkeifer jkeifer jkeifer left review comments

@CloudNiner CloudNiner CloudNiner left review comments

@parksjr parksjr parksjr left review comments

Assignees

@parksjr parksjr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing /products/{productId}/parameters endpoint
5 participants
@austin-sidekick @parksjr @c-wygoda @jkeifer @CloudNiner