Enable mypy in pre-commit, and fix issues found by it #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-wygoda
approved these changes
Nov 12, 2024
|
@c-wygoda could you merge this as an administrator? I can't because the removed |
|
removed |
jkeifer
reviewed
Nov 14, 2024
| @@ -16,7 +16,7 @@ class OrderProperties(BaseModel): | |||
| class Order(Feature[Geometry, OrderProperties]): | |||
| # We need to enforce that orders have an id defined, as that is required to | |||
| # retrieve them via the API | |||
| id: StrictInt | StrictStr # type: ignore | |||
There was a problem hiding this comment.
# type: ignore here is required to satisfy certain type checkers (pyright) because this change makes id incompatible with Feature (which has id: StrictInt | StrictStr | None) without a default value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced the existing custom pre-commit action with a simpler (non-cached) call to run it directly. If we want to do it right, we should be using https://github.com/marketplace/pre-commit-ci, but this will suffice for now.