feat(starknet_l1_provider): add the trait interface for L1 gas price provider #3792
Conversation
|
This change is |
guy-starkware
force-pushed
the
guyn/l1price/contract_functions
branch
from
f9de65f to
4fd24cf
Compare
guy-starkware
force-pushed
the
guyn/l1price/provider_interface
branch
from
14e5338 to
7c61569
Compare
guy-starkware
force-pushed
the
guyn/l1price/contract_functions
branch
from
4fd24cf to
7be5ae4
Compare
guy-starkware
force-pushed
the
guyn/l1price/provider_interface
branch
from
7c61569 to
f9e47dd
Compare
guy-starkware
changed the title
guy-starkware
force-pushed
the
guyn/l1price/contract_functions
branch
from
7be5ae4 to
3e15172
Compare
guy-starkware
force-pushed
the
guyn/l1price/provider_interface
branch
from
f9e47dd to
740fc7b
Compare
guy-starkware
force-pushed
the
guyn/l1price/contract_functions
branch
2 times, most recently
from
4670244 to
3e0c217
Compare
guy-starkware
force-pushed
the
guyn/l1price/provider_interface
branch
from
740fc7b to
4dcedb4
Compare
guy-starkware
force-pushed
the
guyn/l1price/contract_functions
branch
from
3e0c217 to
fae7015
Compare
guy-starkware
force-pushed
the
guyn/l1price/provider_interface
branch
from
4dcedb4 to
9803183
Compare
guy-starkware
force-pushed
the
guyn/l1price/contract_functions
branch
from
fae7015 to
cbaa0d6
Compare
guy-starkware
force-pushed
the
guyn/l1price/provider_interface
branch
from
9803183 to
6bf02d6
Compare
guy-starkware
force-pushed
the
guyn/l1price/contract_functions
branch
from
cbaa0d6 to
6d0ed1b
Compare
guy-starkware
force-pushed
the
guyn/l1price/provider_interface
branch
from
6bf02d6 to
24cada3
Compare
guy-starkware
changed the base branch from
guyn/l1price/contract_functions
to
main
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guy-starkware)
a discussion (no related file):
Interface looks fine.
Please move to a new crate starknet_l1_price_provider
This crate will need to be renamed starknet_l1_handler_provider
guy-starkware
force-pushed
the
guyn/l1price/provider_interface
branch
from
24cada3 to
ece1129
Compare
There was a problem hiding this comment.
Reviewed 7 of 7 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guy-starkware)
crates/starknet_l1_gas_price/Cargo.toml line 0 at r2 (raw file):
Run cargo machete
guy-starkware
force-pushed
the
guyn/l1price/provider_interface
branch
2 times, most recently
from
852008c to
450282a
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:
guy-starkware
force-pushed
the
guyn/l1price/provider_interface
branch
from
450282a to
73e55cf
Compare
There was a problem hiding this comment.
Reviewed 2 of 8 files at r2, 2 of 2 files at r3, 4 of 4 files at r4, all commit messages.
Reviewable status:
No description provided.