refactor(papyrus_base_layer): consolidate alloy crates #3999
Conversation
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ArniStarkware
force-pushed
the
arni/alloy/simplify_price_sample_creation
branch
from
19a0e06 to
da1bd03
Compare
|
Benchmark movements: |
ArniStarkware
force-pushed
the
arni/alloy/consolidate_alloy_crates
branch
from
7c3a974 to
3db5066
Compare
ArniStarkware
force-pushed
the
arni/alloy/consolidate_alloy_crates
branch
from
3db5066 to
cbd0e44
Compare
ArniStarkware
changed the base branch from
arni/alloy/simplify_price_sample_creation
to
arni/alloy/update_versions
ArniStarkware
force-pushed
the
arni/alloy/update_versions
branch
from
5796360 to
ce33ef7
Compare
ArniStarkware
force-pushed
the
arni/alloy/consolidate_alloy_crates
branch
from
cbd0e44 to
75aafa7
Compare
|
Benchmark movements: |
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5)
crates/starknet_l1_provider/Cargo.toml line 29 at r1 (raw file):
[dev-dependencies] alloy = { workspace = true, features = ["json-rpc", "node-bindings"] }
Is this needed?
Code quote:
"json-rpc"
|
+reviewer:@alonh5 |
ArniStarkware
force-pushed
the
arni/alloy/consolidate_alloy_crates
branch
from
75aafa7 to
03fb669
Compare
ArniStarkware
changed the base branch from
arni/alloy/update_versions
to
main
There was a problem hiding this comment.
Reviewable status: 6 of 11 files reviewed, 1 unresolved discussion (waiting on @alonh5)
crates/starknet_l1_provider/Cargo.toml line 29 at r1 (raw file):
Previously, alonh5 (Alon Haramati) wrote…
Is this needed?
No!
- Good job being aware. I just assumed it was needed from Gilad's code.
- Also fixed in other
.tomlfile.
crates/papyrus_base_layer/Cargo.toml line 15 at r2 (raw file):
[dependencies] alloy = { workspace = true, features = ["contract", "json-rpc", "rpc-types"] }
All of these are necessary features (including node-binding)
Code quote:
[features]
testing = ["alloy/node-bindings", "colored", "tar", "tempfile"]
[dependencies]
alloy = { workspace = true, features = ["contract", "json-rpc", "rpc-types"] }
ArniStarkware
force-pushed
the
arni/alloy/consolidate_alloy_crates
branch
from
03fb669 to
f02aa17
Compare
There was a problem hiding this comment.
Reviewed 2 of 5 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: 10 of 11 files reviewed, all discussions resolved (waiting on @giladchase)
crates/papyrus_base_layer/Cargo.toml line 15 at r2 (raw file):
Previously, ArniStarkware (Arnon Hod) wrote…
All of these are necessary features (including
node-binding)
Great! How did you check which were needed and which weren't?
There was a problem hiding this comment.
Reviewed 1 of 5 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @giladchase)
There was a problem hiding this comment.
Reviewable status:
crates/papyrus_base_layer/Cargo.toml line 15 at r2 (raw file):
Previously, alonh5 (Alon Haramati) wrote…
Great! How did you check which were needed and which weren't?
I turned them all off, then added them according to the error messages, one by one.
Use alloy + features instead of individual crates to consolidate
versioning.
There are no logic changes, only import changes.
Warning: Alloy has tons of features; don't activate features greedily; otherwise, our compilation time will suffer.