feat(starknet_patricia,starknet_committer): stop using custom CompiledClassHash type

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat(starknet_patricia,starknet_committer): stop using custom CompiledClassHash type #4005 👈 (View in Graphite)
• feat(starknet_patricia,starknet_committer): stop using custom Nonce type #4004
• feat(starknet_patricia,starknet_committer): stop using custom ClassHash type #4003
• feat(starknet_patricia,starknet_committer): stop using custom ContractAddress type #4002
• feat(starknet_patricia,starknet_committer): stop using custom Felt type #4001
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[dorimedini-starkware]

Reviewable status: 0 of 17 files reviewed, all discussions resolved

---

crates/starknet_patricia/src/patricia_merkle_tree/node_data/leaf_impls.rs line 0 at r1 (raw file):
problem:

1. the CompiledClassHash is defined in starknet_api
2. the Storage traits DBObject, Deserializable are defined in starknet_patricia (for the commitment computation abstraction)
3. the starknet_committer requires the CompiledClassHash implement these traits.

we can't implement (2) for (1) in starknet_committer... we can implement it in starknet_patricia, but that hurts the separation (the generic patricia crate is now "aware" that the compiled class hash can be a leaf type)...

hopefully we will be able to remove these storage traits in the future if we work with other APIs..?

[dorimedini-starkware]

Reviewable status: 0 of 17 files reviewed, all discussions resolved

---

a discussion (no related file):
py side

[dorimedini-starkware]

Reviewable status: 0 of 17 files reviewed, all discussions resolved

---

crates/starknet_patricia/src/patricia_merkle_tree/node_data/leaf_impls.rs line at r1 (raw file):

Previously, dorimedini-starkware wrote…

problem:

1. the CompiledClassHash is defined in starknet_api
2. the Storage traits DBObject, Deserializable are defined in starknet_patricia (for the commitment computation abstraction)
3. the starknet_committer requires the CompiledClassHash implement these traits.

we can't implement (2) for (1) in starknet_committer... we can implement it in starknet_patricia, but that hurts the separation (the generic patricia crate is now "aware" that the compiled class hash can be a leaf type)...

hopefully we will be able to remove these storage traits in the future if we work with other APIs..?

this PR should wait until this stack is merged, after which we will be able to implement storage related traits directly in the starknet_api crate.
Should probably be gated behind a patricia_storage feature though

[github-actions]

Artifacts upload workflows:

• Started at 2025-02-11T20:37:39Z