relation tracker preprocessed bug fix

[ohad-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ohad-starkware]

• relation tracker preprocessed bug fix #1002 👈 (View in Graphite)
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.92%. Comparing base (c2e1a6a) to head (3114bd5).

Files with missing lines	Patch %	Lines
...rover/src/constraint_framework/relation_tracker.rs	92.85%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #1002      +/-   ##
==========================================
- Coverage   92.93%   92.92%   -0.01%     
==========================================
  Files         105      105              
  Lines       14239    14243       +4     
  Branches    14239    14243       +4     
==========================================
+ Hits        13233    13236       +3     
  Misses        927      927              
- Partials       79       80       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shaharsamocha7]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ohad-starkware)

---

crates/prover/src/constraint_framework/relation_tracker.rs line 44 at r2 (raw file):

        let component = FrameworkComponent::<E>::new(location_allocator, eval, QM31::default());

        // Interaction trace is no needed and might not exist when relation tracker is ran.

I see why you wrote this (for explaining the truncate), but I don't think the second part is necessary.
Also might not exists is scary

Suggestion:

 // Interaction trace is no needed for relation tracker.

[shaharsamocha7]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)

[ohad-starkware]

Merge activity

• Jan 30, 12:52 PM EST: A user merged this pull request with Graphite.