Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallel batch inverse #984

Merged
merged 1 commit into from
Jan 29, 2025
Merged

parallel batch inverse #984

merged 1 commit into from
Jan 29, 2025

Conversation

ohad-starkware
Copy link
Collaborator

No description provided.

This was referenced Jan 13, 2025
Copy link
Collaborator Author

ohad-starkware commented Jan 13, 2025

@reviewable-StarkWare
Copy link

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (5345457) to head (1692003).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #984   +/-   ##
=======================================
  Coverage   92.90%   92.91%           
=======================================
  Files         105      105           
  Lines       14231    14242   +11     
  Branches    14231    14242   +11     
=======================================
+ Hits        13222    13233   +11     
  Misses        930      930           
  Partials       79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ohad-starkware ohad-starkware changed the base branch from ohad/chunked_batch_inverse to graphite-base/984 January 13, 2025 13:35
@ohad-starkware ohad-starkware force-pushed the ohad/parallel_batch_inverse branch from 575aca9 to f3243ea Compare January 13, 2025 13:35
@ohad-starkware ohad-starkware changed the base branch from graphite-base/984 to ohad/specific_batch_inverse January 13, 2025 13:35
@ohad-starkware ohad-starkware self-assigned this Jan 13, 2025
@ohad-starkware ohad-starkware force-pushed the ohad/parallel_batch_inverse branch from f3243ea to 3fcae0e Compare January 13, 2025 13:39
@ohad-starkware ohad-starkware force-pushed the ohad/specific_batch_inverse branch from eeeccf7 to 9d80d73 Compare January 13, 2025 13:39
@ohad-starkware ohad-starkware force-pushed the ohad/specific_batch_inverse branch from 9d80d73 to 80513ec Compare January 14, 2025 08:32
@ohad-starkware ohad-starkware force-pushed the ohad/parallel_batch_inverse branch from 3fcae0e to fbfd130 Compare January 14, 2025 08:33
@ohad-starkware ohad-starkware force-pushed the ohad/specific_batch_inverse branch from 80513ec to 302f0dd Compare January 14, 2025 11:33
@ohad-starkware ohad-starkware force-pushed the ohad/parallel_batch_inverse branch from fbfd130 to 13219eb Compare January 14, 2025 11:33
@ohad-starkware ohad-starkware force-pushed the ohad/specific_batch_inverse branch from 302f0dd to f6b261b Compare January 14, 2025 14:09
@ohad-starkware ohad-starkware force-pushed the ohad/parallel_batch_inverse branch from 13219eb to 6018cd7 Compare January 14, 2025 14:09
@ohad-starkware ohad-starkware force-pushed the ohad/specific_batch_inverse branch from f6b261b to 109fb1f Compare January 14, 2025 14:51
@ohad-starkware ohad-starkware force-pushed the ohad/parallel_batch_inverse branch from 6018cd7 to 4502270 Compare January 14, 2025 14:51
@ohad-starkware ohad-starkware force-pushed the ohad/specific_batch_inverse branch from 109fb1f to 47292dd Compare January 14, 2025 16:05
@ohad-starkware ohad-starkware force-pushed the ohad/parallel_batch_inverse branch 2 times, most recently from 682a4c4 to 799324a Compare January 14, 2025 16:13
@ohad-starkware ohad-starkware force-pushed the ohad/specific_batch_inverse branch 2 times, most recently from 760ee74 to dac1f59 Compare January 14, 2025 16:18
@ohad-starkware ohad-starkware force-pushed the ohad/parallel_batch_inverse branch from 799324a to 333e755 Compare January 14, 2025 16:18
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)

@ohad-starkware ohad-starkware force-pushed the ohad/parallel_batch_inverse branch from 333e755 to 30b8eda Compare January 23, 2025 13:26
@ohad-starkware ohad-starkware force-pushed the ohad/specific_batch_inverse branch from dac1f59 to 03135cd Compare January 23, 2025 13:26
Copy link
Collaborator Author

ohad-starkware commented Jan 29, 2025

Merge activity

  • Jan 29, 4:50 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 29, 4:53 AM EST: Graphite rebased this pull request as part of a merge.
  • Jan 29, 4:56 AM EST: A user merged this pull request with Graphite.

@ohad-starkware ohad-starkware changed the base branch from ohad/specific_batch_inverse to graphite-base/984 January 29, 2025 09:51
@ohad-starkware ohad-starkware changed the base branch from graphite-base/984 to dev January 29, 2025 09:51
@ohad-starkware ohad-starkware force-pushed the ohad/parallel_batch_inverse branch from 30b8eda to 1692003 Compare January 29, 2025 09:52
@ohad-starkware ohad-starkware merged commit 7b831a2 into dev Jan 29, 2025
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants