-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor commit_inner_layers #986
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #986 +/- ##
=======================================
Coverage 91.91% 91.92%
=======================================
Files 105 105
Lines 14289 14295 +6
Branches 14289 14295 +6
=======================================
+ Hits 13134 13140 +6
Misses 1081 1081
Partials 74 74 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alon-f and @ilyalesokhin-starkware)
crates/prover/src/core/fri.rs
line 197 at r1 (raw file):
/// Builds and commits to the inner FRI layers (all layers except the first and last). /// /// All `columns` must be provided in descending order by size.
Can you change the doc so it would be clear that we only have a single column of each size?
Code quote:
/// All `columns` must be provided in descending order by size.
c4d2235
to
4e670fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware and @shaharsamocha7)
crates/prover/src/core/fri.rs
line 197 at r1 (raw file):
Previously, shaharsamocha7 wrote…
Can you change the doc so it would be clear that we only have a single column of each size?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
4e670fb
to
0a1c1cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware and @shaharsamocha7)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
0a1c1cc
to
21685f2
Compare
No description provided.