Struct for PreProcessed Columns ID

[Gali-StarkWare]

No description provided.

[reviewable-StarkWare]

This change is 

[Gali-StarkWare]

• Struct for PreProcessed Columns ID #992 👈 (View in Graphite)
• Remove PreProcessedColumn Enum #968
• Use PreProcessedColumn Structs and String Instead of Enum #967
• Add PreprocessedColumn Structs #966
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.37%. Comparing base (cfb5031) to head (9d46c4c).

Files with missing lines	Patch %	Lines
...rates/prover/src/constraint_framework/component.rs	50.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##              dev     #992   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files         105      105           
  Lines       14218    14224    +6     
  Branches    14218    14224    +6     
=======================================
+ Hits        13134    13140    +6     
  Misses       1010     1010           
  Partials       74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ohad-starkware]

Reviewed 8 of 9 files at r1, all commit messages.
Reviewable status: 8 of 9 files reviewed, all discussions resolved (waiting on @shaharsamocha7)

---

crates/prover/src/constraint_framework/component.rs line 103 at r1 (raw file):

    // I.e. preprocessed_columns[i] == self.preprocessed_columns[i].
    pub fn validate_preprocessed_columns(&self, preprocessed_columns: &[PreProcessedColumnId]) {
        assert_eq!(self.preprocessed_columns, preprocessed_columns);

unrelated to this pr, this needs to assert that they are permutations, correct? it just happens to be the case with state machine that the order in the tree matches the usage order.

[Gali-StarkWare]

Reviewable status: 8 of 9 files reviewed, all discussions resolved (waiting on @shaharsamocha7)

---

crates/prover/src/constraint_framework/component.rs line 103 at r1 (raw file):

this needs to assert that they are permutations, correct?

Great question, not sure. @shaharsamocha7 wdyt?

[shaharsamocha7]

Reviewed 4 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Gali-StarkWare)

---

crates/prover/src/constraint_framework/component.rs line 103 at r1 (raw file):

Previously, Gali-StarkWare wrote…

this needs to assert that they are permutations, correct?

Great question, not sure. @shaharsamocha7 wdyt?

Should be fixed in another pr

---

crates/prover/src/constraint_framework/preprocessed_columns.rs line 17 at r1 (raw file):

pub struct PreProcessedColumnId {
    pub id: String,
}

Currently you added an Id function to all the structs that implement this.
Maybe we just want to implement the From trait for each of those structs?
@ohad-starkware WDYT?

Code quote:

#[derive(Debug, Clone, PartialEq, Eq, Hash)]
pub struct PreProcessedColumnId {
    pub id: String,
}

[Gali-StarkWare]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ohad-starkware)

---

crates/prover/src/constraint_framework/preprocessed_columns.rs line 17 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Currently you added an Id function to all the structs that implement this.
Maybe we just want to implement the From trait for each of those structs?
@ohad-starkware WDYT?

How will you include the variables' values as well there?

[shaharsamocha7]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)

[Gali-StarkWare]

Merge activity

• Jan 14, 9:01 AM EST: A user started a stack merge that includes this pull request via Graphite.
• Jan 14, 9:03 AM EST: Graphite rebased this pull request as part of a merge.
• Jan 14, 9:06 AM EST: A user merged this pull request with Graphite.