Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use verbb/knock-knock to protect/lock the site #290

Merged
merged 18 commits into from
May 16, 2024
Merged

Use verbb/knock-knock to protect/lock the site #290

merged 18 commits into from
May 16, 2024

Conversation

janhenckens
Copy link
Member

@janhenckens janhenckens commented Feb 29, 2024 •
edited
Loading

Description

Trekt de configuratie van de "bescherming" in het CMS en uit htaccess/htpasswd, waardoor we het ineens over meerdere sites & omgevingen kunnen instellen, van op 1 plek.

Nog uit te klaren:

  • Willen we een eigen template maken (docs)?
  • Standaard route of eigen url kiezen?

@janhenckens janhenckens marked this pull request as ready for review February 29, 2024 14:09
@janhenckens janhenckens marked this pull request as draft March 7, 2024 12:10
@janhenckens janhenckens marked this pull request as ready for review March 12, 2024 11:58
@janhenckens janhenckens requested a review from Numkil March 12, 2024 11:58
@Numkil
Copy link
Contributor

Numkil commented Mar 21, 2024 •
edited
Loading

We hebben het besproken op de craft gilde.

We zouden nog graag de volgende dingen toevoegen 👍

  • Template maken met correcte uitleg voor de klant. Anton wou wel een designtje maken.
  • robots Noindex toevoegen
  • IP addressen statik kantoor + url logo voor email in config zetten zodat ide standaard zijn gewhitelist.
  • Eventueel in help.statik een video er over maken.

@janhenckens
Copy link
Member Author

@AntonLecock Zullen we samen eens kijken wat die template kan zijn?

@janhenckens
Copy link
Member Author

Ik heb een template ingesteld & klaar gezet, zorg jij voor een layout @KarelJanVanHaute ?

@janhenckens janhenckens marked this pull request as draft March 28, 2024 09:04
@janhenckens
Merge branch 'release/3.8.0'
9fcc09b
@janhenckens
Merge tag '3.8.0' into develop
d8aa7b4 
3.8.0

# -----BEGIN PGP SIGNATURE-----
#
# iQEzBAABCAAdFiEEVBSlbiL0qLa3a6e2dY74HTSpJWcFAmYX07UACgkQdY74HTSp
# JWduigf/W/DS+qBcffr2cQ+Fo/SZ1k1i3Wa0nnbwukxzvTOOR9GuL7k71a4X4T6Y
# nipqAtB3Eskp0nVsjbxpo/oF4/ZxB99EVgxQ+n2ZFHqf4uiav98oT5x8qsFkat4w
# w7EVL4xCUBXSUTu6PeDCq48OqAEtQkWkMD49gO0ZZ6staN49MApd6v37vFbrmC+S
# ITHnWy7Do6EzMPFUdYCO4l5Pdt0xXzgDyAfbbEIeVwUkjtM/Gl0DRxJ1oy85lI8I
# bmvZ+o6s0VR8gdPJYxej+agUvc+8LjLiyq8lLbKTRY+FayGnkGZYGwCXqohWXU9l
# 87XlON7GeEP5ZplO7M/r6a6WEUGMRQ==
# =w2Xx
# -----END PGP SIGNATURE-----
# gpg: Signature made Thu Apr 11 14:12:37 2024 CEST
# gpg:                using RSA key 5414A56E22F4A8B6B76BA7B6758EF81D34A92567
# gpg: Good signature from "Jan Henckens <jan@statik.be>" [ultimate]
@janhenckens
Copy link
Member Author

On second thought, misschien is het beter om deze nu al te mergen (zodat we deze verbetering sneller in meer projecten hebben) en dan te maken in de planning wanneer we een template kunnen maken - anders gaat deze nog lang blijven open staan vrees ik... Wat denken jullie @KarelJanVanHaute @Numkil ?

@Numkil Numkil self-assigned this Apr 18, 2024
@janhenckens
Copy link
Member Author

Merge opgelost, kan jij nog eens kijken @Numkil?

HannahDeWachter
HannahDeWachter requested changes May 13, 2024
View reviewed changes
@janhenckens
Updated email logo path
486fe0f
@janhenckens
Merge branch 'develop' into knock-knock
15cc07a 
# Conflicts:
#	composer.json
#	composer.lock
#	config/project/project.yaml
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@janhenckens janhenckens marked this pull request as ready for review May 16, 2024 06:41
@janhenckens janhenckens merged commit d23f459 into develop May 16, 2024
2 of 3 checks passed
@janhenckens janhenckens deleted the knock-knock branch May 16, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HannahDeWachter HannahDeWachter HannahDeWachter approved these changes

@Numkil Numkil Awaiting requested review from Numkil

Assignees

@Numkil Numkil

@KarelJanVanHaute KarelJanVanHaute

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@janhenckens @Numkil @HannahDeWachter @KarelJanVanHaute