fix: amend incorrect int bound check #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that a test for the edge case being addressed here would be great. |
Great idea! Just added a couple tests and fixed some bugs I had missed :) |
etan-status
reviewed
Nov 22, 2023
etan-status
approved these changes
Nov 22, 2023
Ivansete-status
approved these changes
Nov 24, 2023
etan-status
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
int64 numbers range from
-9,223,372,036,854,775,808to9,223,372,036,854,775,807.When checking if an int64 is in a valid range, we have to check whether its absolute value is smaller or equal than
9,223,372,036,854,775,808for negative numbers, and smaller or equal than9,223,372,036,854,775,807for positive numbers.Without this fix,
9,223,372,036,854,775,808is taken as a valid int64 number which is not.