Writer produce correct top-level or in-array optional elem when custo… #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m flavor omit optional fields
zah
reviewed
Jan 11, 2024
| test "results option array some MyJson": | ||
| var val = [Opt.some(123), Opt.some(345)] | ||
| let json = MyJson.encode(val) | ||
| check json == "[123,345]" |
There was a problem hiding this comment.
Hrm, I think the semantics proposed here could be very surprising for the user. Omitting optional fields in objects in one thing, but filtering such values out of array, so the array length is effectively changed is something that feels much more dangerous.
We could have a separate policy setting that controls this aspect perhaps.
There was a problem hiding this comment.
No, I don't change the array length. The old code is wrong. It didn't output anything between two comma which is violating the spec. Now it works correctly by writing null to that position in the array. It's correct according to the json spec and the rpc spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…m flavor omit optional fields