chore: align buying/releasing/setting ens usernames with the new sending flow #16440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saledjenic
requested review from
alaibe,
Cuteivist,
Khushboo-dev-cpp,
anastasiyaig and
a team
saledjenic
changed the title
…ing flow Based on changes done in this PR status-im/status-go#5807 we can simplify our client logic a lot. This results in the removal of many lines of code that are no longer needed Closes 2nd part of #16336
saledjenic
force-pushed
the
fix/issue-16336-part-2
branch
from
6481253 to
867818f
Compare
Jenkins Builds
|
virginiabalducci
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Tested these flows:
- buying stickers
- buying ens name
- setting ens name
Given that there is no option to release an ens name, this was not covered in the testing.
There is a known issue when changing accounts when buying ens names or stickers but it is being addressed in #16404 (comment)
anastasiyaig
approved these changes
Oct 2, 2024
alaibe
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on changes done in this PR status-im/status-go#5807 we can simplify our client logic a lot.
This results in the removal of many lines of code that are no longer needed
Closes 2nd part of #16336