feat_: disable tx history fetching for all accounts

api/geth_backend.go

@@ -1613,7 +1613,6 @@ func (b *GethStatusBackend) prepareSettings(request *requests.CreateAccount, inp
 	settings.TestNetworksEnabled = request.TestNetworksEnabled
 	if !input.restoringAccount {
 		settings.Mnemonic = &input.mnemonic
-		settings.OmitTransfersHistoryScan = true
 		// TODO(rasom): uncomment it as soon as address will be properly
 		// marked as shown on mobile client
 		//settings.MnemonicWasNotShown = true

appdatabase/migrations/sql/1724939813_remove_omit_transfers_history_scan_from_settings.up.sql

@@ -0,0 +1 @@
+ALTER TABLE settings DROP COLUMN omit_transfers_history_scan;

mobile/status.go

@@ -420,7 +420,6 @@ func SaveAccountAndLogin(accountData, password, settingsJSON, configJSON, subacc
 	}
 
 	if *settings.Mnemonic != "" {
-		settings.OmitTransfersHistoryScan = true
 		settings.MnemonicWasNotShown = true
 	}
 

multiaccounts/settings/columns.go

@@ -496,11 +496,6 @@ var (
 			protobufType:      protobuf.SyncSetting_URL_UNFURLING_MODE,
 		},
 	}
-	OmitTransfersHistoryScan = SettingField{
-		reactFieldName: "omit-transfers-history-scan",
-		dBColumnName:   "omit_transfers_history_scan",
-		valueHandler:   BoolHandler,
-	}
 	MnemonicWasNotShown = SettingField{
 		reactFieldName: "mnemonic-was-not-shown?",
 		dBColumnName:   "mnemonic_was_not_shown",

multiaccounts/settings/database.go

@@ -142,7 +142,6 @@ INSERT INTO settings (
   profile_pictures_show_to,
   profile_pictures_visibility,
   url_unfurling_mode,
-  omit_transfers_history_scan,
   mnemonic_was_not_shown,
   wallet_token_preferences_group_by_community,
   wallet_collectible_preferences_group_by_collection,
@@ -151,7 +150,7 @@ INSERT INTO settings (
   fleet
 ) VALUES (
 ?,?,?,?,?,?,?,?,?,?,?,?,?,?,
-?,?,?,?,?,?,?,?,?,'id',?,?,?,?,?,?,?,?,?,?,?)`,
+?,?,?,?,?,?,?,?,?,'id',?,?,?,?,?,?,?,?,?,?)`,
 		s.Address,
 		s.Currency,
 		s.CurrentNetwork,
@@ -179,7 +178,6 @@ INSERT INTO settings (
 		s.ProfilePicturesShowTo,
 		s.ProfilePicturesVisibility,
 		s.URLUnfurlingMode,
-		s.OmitTransfersHistoryScan,
 		s.MnemonicWasNotShown,
 		s.TokenGroupByCommunity,
 		s.CollectibleGroupByCollection,
@@ -388,7 +386,7 @@ func (db *Database) GetSettings() (Settings, error) {
 		waku_bloom_filter_mode, webview_allow_permission_requests, current_user_status, send_status_updates, gif_recents,
 		gif_favorites, opensea_enabled, last_backup, backup_enabled, telemetry_server_url, auto_message_enabled, gif_api_key,
 		test_networks_enabled, mutual_contact_enabled, profile_migration_needed, is_goerli_enabled, wallet_token_preferences_group_by_community, url_unfurling_mode,
-		omit_transfers_history_scan, mnemonic_was_not_shown, wallet_show_community_asset_when_sending_tokens, wallet_display_assets_below_balance,
+		mnemonic_was_not_shown, wallet_show_community_asset_when_sending_tokens, wallet_display_assets_below_balance,
 		wallet_display_assets_below_balance_threshold, wallet_collectible_preferences_group_by_collection, wallet_collectible_preferences_group_by_community, 
 		peer_syncing_enabled
 	FROM
@@ -467,7 +465,6 @@ func (db *Database) GetSettings() (Settings, error) {
 		&s.IsGoerliEnabled,
 		&s.TokenGroupByCommunity,
 		&s.URLUnfurlingMode,
-		&s.OmitTransfersHistoryScan,
 		&s.MnemonicWasNotShown,
 		&s.ShowCommunityAssetWhenSendingTokens,
 		&s.DisplayAssetsBelowBalance,

multiaccounts/settings/structs.go

@@ -150,12 +150,11 @@ type Settings struct {
 	MessagesFromContactsOnly  bool             `json:"messages-from-contacts-only"`
 	Mnemonic                  *string          `json:"mnemonic,omitempty"`
 	// NOTE(rasom): negation here because it safer/simpler to have false by default
-	MnemonicWasNotShown      bool             `json:"mnemonic-was-not-shown?,omitempty"`
-	MnemonicRemoved          bool             `json:"mnemonic-removed?,omitempty"`
-	OmitTransfersHistoryScan bool             `json:"omit-transfers-history-scan?,omitempty"`
-	MutualContactEnabled     bool             `json:"mutual-contact-enabled?"`
-	Name                     string           `json:"name,omitempty"`
-	Networks                 *json.RawMessage `json:"networks/networks"`
+	MnemonicWasNotShown  bool             `json:"mnemonic-was-not-shown?,omitempty"`
+	MnemonicRemoved      bool             `json:"mnemonic-removed?,omitempty"`
+	MutualContactEnabled bool             `json:"mutual-contact-enabled?"`
+	Name                 string           `json:"name,omitempty"`
+	Networks             *json.RawMessage `json:"networks/networks"`
 	// NotificationsEnabled indicates whether local notifications should be enabled (android only)
 	NotificationsEnabled bool             `json:"notifications-enabled?,omitempty"`
 	PhotoPath            string           `json:"photo-path"`

services/wallet/transfer/controller.go

@@ -13,7 +13,6 @@ import (
 	"github.com/ethereum/go-ethereum/event"
 	"github.com/ethereum/go-ethereum/log"
 	statusaccounts "github.com/status-im/status-go/multiaccounts/accounts"
-	"github.com/status-im/status-go/multiaccounts/settings"
 	"github.com/status-im/status-go/rpc"
 	"github.com/status-im/status-go/rpc/chain"
 	"github.com/status-im/status-go/services/accounts/accountsevent"
@@ -120,21 +119,7 @@ func (c *Controller) CheckRecentHistory(chainIDs []uint64, accounts []common.Add
 		return nil
 	}
 
-	omitHistory := false
-	multiaccSettings, err := c.accountsDB.GetSettings()
-	if err != nil {
-		log.Error("Failed to get multiacc settings") // not critical
-	} else {
-		omitHistory = multiaccSettings.OmitTransfersHistoryScan
-	}
-
-	if omitHistory {
-		err := c.accountsDB.SaveSettingField(settings.OmitTransfersHistoryScan, false)
-		if err != nil {
-			return err
-		}
-	}
-
+	const omitHistory = true
 	c.reactor = NewReactor(c.db, c.blockDAO, c.blockRangesSeqDAO, c.accountsDB, c.TransferFeed, c.transactionManager,
 		c.pendingTxManager, c.tokenManager, c.balanceCacher, omitHistory, c.blockChainState)