Skip to content

Commit

Permalink
fix(suggested-fees)_: crash caused by null GasPrice (#6274)
Browse files Browse the repository at this point in the history
* fix_: suggested fees crash caused by null GasPrice

* fix_: tests

---------

Co-authored-by: Andrey Bocharnikov <andrey.bocharnikov@gmail.com>
  • Loading branch information
clauxx and friofry authored Jan 24, 2025
1 parent 7bb4cf1 commit e71fdbc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions services/wallet/router/fees/fees.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ func (f *FeeManager) SuggestedFees(ctx context.Context, chainID uint64) (*Sugges
}

return &SuggestedFees{
GasPrice: big.NewInt(0),
BaseFee: baseFee,
CurrentBaseFee: baseFee,
MaxPriorityFeePerGas: maxPriorityFeePerGas,
Expand Down
2 changes: 1 addition & 1 deletion services/wallet/router/fees/fees_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ func TestSuggestedFeesForEIP1559CompatibleChains(t *testing.T) {
assert.NoError(t, err)
assert.NotNil(t, suggestedFees)

assert.Nil(t, suggestedFees.GasPrice)
assert.Equal(t, big.NewInt(0), suggestedFees.GasPrice)
assert.Equal(t, big.NewInt(6958609414), suggestedFees.BaseFee)
assert.Equal(t, big.NewInt(6958609414), suggestedFees.CurrentBaseFee)
assert.Equal(t, big.NewInt(7928609414), suggestedFees.MaxFeesLevels.Low.ToInt())
Expand Down

0 comments on commit e71fdbc

Please sign in to comment.