feat(mentions): add callID for OnChangeText
#3806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qfrank
force-pushed
the
fix/issue-relate-to-mobile-pr-16330-2
branch
from
76e0d00 to
0b585ed
Compare
Jenkins BuildsClick to see older builds (45)
|
vkjr
approved these changes
Jul 26, 2023
ilmotta
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Interestingly @vkjr @qfrank, I solved a similar problem at the re-frame event layer for generating link previews. Basically, by the time any re-frame event is dispatched, it is processed asynchronously in an event queue, and by the time status-go response arrives to the client, new events may have been dispatched already.
So in effect, the pattern I used is a known one, which is to use a unique request ID to allow event de-duplication. The client only changes the application state (aka app-db) if the response ID is the same as the originating request ID. One difference is that I used a UUID to generate unique request IDs.
If you are curious, here's how I implemented this (very roughly I must say) in status-mobile https://github.com/status-im/status-mobile/blob/238e35a281a108ec2cac2091ca1f1ef84e106e80/src/status_im2/contexts/chat/composer/link_preview/events.cljs#L43
There are interesting ways to create a general solution in the client side too, because high-frequency client events that happen faster than the backend can reply can usually suffer from the problem this PR solved and the problem I solved on the client.
Well, thanks for reading this much :)
qfrank
force-pushed
the
fix/issue-relate-to-mobile-pr-16330-2
branch
2 times, most recently
from
79aeba7 to
9d36da0
Compare
|
@qfrank is this PR still needed? |
I'd say yes and now one of our focus is stability, this will improve the stability of the application. Time to merge after manual QA @igor-sirotin |
@qfrank can you please rebase it then and request manual QA? |
ofc, I planned today, but I got something more important to do today, I'll do it tomorrow |
qfrank
force-pushed
the
fix/issue-relate-to-mobile-pr-16330-2
branch
2 times, most recently
from
53d2c03 to
0210a02
Compare
igor-sirotin
changed the title
OnChangeTextOnChangeText
qfrank
force-pushed
the
fix/issue-relate-to-mobile-pr-16330-2
branch
from
0210a02 to
a1010b3
Compare
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
qfrank
force-pushed
the
fix/issue-relate-to-mobile-pr-16330-2
branch
from
a1010b3 to
b2c2e40
Compare
qfrank
force-pushed
the
fix/issue-relate-to-mobile-pr-16330-2
branch
from
cab93fa to
3f8962b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relate mobile PR1 PR2