Orphaned generated code

[Azanul]

Closes #3677

[ghost]

Hey @Azanul, and thank you so much for making your first pull request in status-go! ❤️ Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2

[igor-sirotin]

@Azanul thank you for your contribution and congrats on your first PR.
Sorry for the long review 😄

Please rebase to the latest develop branch to make all CI checks pass, and I'll merge it in.

[Azanul]

@igor-sirotin I think the branch is up to date

[igor-sirotin]

@igor-sirotin I think the branch is up to date

Your fork is 1282 commits behind latest develop in status-im/status-go.

Because of this (I think) CI checks are not running, there're something outdated.

[status-im-auto]

Jenkins Builds

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✖️	cc3f646	#1	2024-08-31 09:15:53	~1 min	tests	📄log
✔️	933a750	#1	2024-09-03 18:22:29	~2 min	tests-rpc	📄log
✔️	933a750	#1	2024-09-03 18:23:03	~3 min	linux	📦zip
✔️	933a750	#1	2024-09-03 18:23:54	~4 min	ios	📦zip
✔️	933a750	#1	2024-09-03 18:24:18	~5 min	android	📦aar
✔️	933a750	#2	2024-09-03 18:52:50	~32 min	tests	📄log

[igor-sirotin]

@Azanul thanks for updating the fork, I can run all the checks now.
There will be an issue though.

1. We require commit messages to follow Conventional Commits, but with _ for non-breaking changes.
   So in your case it should be something like

   fix_: Orphaned generated code
   

2. We use git rebase strategy over merge strategy.
   So having a merge-commit cc3f646 won't work.
   GitHub might be smart enough to just drop it when merging the PR, but we still require Conventional Commits (look clause 1).

Until this is fixed, CI checks won't pass and, unfortunately, I'll not be able to merge 🙁

---

I suggest you to hard-reset your fork on top of latest develop and cherry-pick 07acd67 on top, while changing the commit message to fix_: Orphaned generated code.
OR use interactive rebase git feature, drop merge commit and rename your commit.

Sorry for such difficulties. But we do this do automatically calculate version/changes based on commit messages.

[igor-sirotin]

@jakubgs how do we work with forks? For such PR, should I start each check manually on Jenkins?
I started tests manually, but I expected it to happen automatically 🤔

[Azanul]

@igor-sirotin Check it out. I rebased, soft reset and re-commit with updated message

[igor-sirotin]

@igor-sirotin Check it out. I rebased, soft reset and re-commit with updated message

Thank you. I'll figure out what's happening with fork jenkins checks and come back to you.

[jakubgs]

Sorry, our permissions model for Jenkins CI only allows jobs to be started for contributors. I've added you to the repo:

Once you accept the invite and you push again to this branch jobs should start.

[Azanul]

Sorry, our permissions model for Jenkins CI only allows jobs to be started for contributors. I've added you to the repo:

Once you accept the invite and you push again to this branch jobs should start.

I did accept and pushed but nothing happend

[igor-sirotin]

I did accept and pushed but nothing happend

Don't worry, everything that should have happened, happened 👍

Thank you for your contribution!