feat(telemetry)_: include device type in metrics #5669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adklempner
force-pushed
the
feat/telemetry-device
branch
from
c64f5d3 to
348e9f2
Compare
adklempner
changed the title
✔️ status-go/prs/tests-rpc/PR-5669#1 🔹 ~2 min 51 sec 🔹 c64f5d3 🔹 📦 tests-rpc package |
Jenkins BuildsClick to see older builds (35)
|
adklempner
force-pushed
the
feat/telemetry-device
branch
2 times, most recently
from
8ec4005 to
c44f9fc
Compare
igor-sirotin
requested changes
Aug 7, 2024
adklempner
force-pushed
the
feat/telemetry-device
branch
from
c44f9fc to
4c5f52e
Compare
igor-sirotin
approved these changes
Aug 8, 2024
adklempner
force-pushed
the
feat/telemetry-device
branch
2 times, most recently
from
711d6d7 to
74f9d5b
Compare
adklempner
force-pushed
the
feat/telemetry-device
branch
from
74f9d5b to
a734ddf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializes telemetry client with device type and includes in all calls to telemetry server.
At the end of
injectAccountsIntoWakuService, finds the installation based on installation ID set in messenger, and calls Waku service to set it in the telemetry client. Does nothing if the telemetry client is not set.Important changes:
Closes #