fix_: send accounts event on handling backed up accounts #5739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (46)
|
smohamedjavid
force-pushed
the
fix/send-account-event-on-handling-backedup-accounts
branch
2 times, most recently
from
abdb2b6 to
60b5499
Compare
smohamedjavid
force-pushed
the
fix/send-account-event-on-handling-backedup-accounts
branch
2 times, most recently
from
cdddb32 to
f8fcc3a
Compare
smohamedjavid
force-pushed
the
fix/send-account-event-on-handling-backedup-accounts
branch
from
f8fcc3a to
e34b2fb
Compare
smohamedjavid
force-pushed
the
fix/send-account-event-on-handling-backedup-accounts
branch
2 times, most recently
from
f2b2d18 to
83dccb1
Compare
dlipicar
reviewed
Aug 29, 2024
| @@ -3376,6 +3379,18 @@ func (m *Messenger) handleSyncWatchOnlyAccount(message *protobuf.SyncAccount, fr | |||
| return nil, err | |||
| } | |||
|
|
|||
| if m.config.accountsFeed != nil { | |||
| var eventType accountsevent.EventType | |||
| if acc.Removed { | |||
There was a problem hiding this comment.
I have absolutely no idea how this sync thingy ends up actually adding or removing the account, are you sure we won't get 2 notifications (sent here and also wherever we had them before) for a single addition/removal?
There was a problem hiding this comment.
I actually was under the impression we had something like a "removeLater" flag when removing through sync, so the actual removal got done on the next app start, but I'm not super sure about that...
There was a problem hiding this comment.
No, that's not the case from what I experienced so far (from UI and checking the go code). When one of the synced devices adds/removes any accounts, it's immediately done, updates the DB and sends a signal to the UI of the same (that's why this function returns the acc).
dlipicar
reviewed
Aug 29, 2024
igor-sirotin
approved these changes
Aug 29, 2024
smohamedjavid
force-pushed
the
fix/send-account-event-on-handling-backedup-accounts
branch
2 times, most recently
from
d599f6e to
71bc099
Compare
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
smohamedjavid
force-pushed
the
fix/send-account-event-on-handling-backedup-accounts
branch
from
71bc099 to
5f2bd7d
Compare
dlipicar
approved these changes
Aug 30, 2024
smohamedjavid
deleted the
fix/send-account-event-on-handling-backedup-accounts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for status-im/status-mobile#18613
Summary
Issue:
The collectables are not fetched whenever a profile is recovered with multiple wallet accounts.
Root cause:
We don't send any accounts event whenever we handle the accounts from backed-up data. This makes watchers fail to react to it.
Changes / fixes:
This PR moves the
accountsFeedfrominitServicesto the status node config, and adds a reference to messenger config for sending events on handling backed-up data.