fix(wallet)_: fix single chain operation check #5784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
alaibe
approved these changes
Aug 29, 2024
saledjenic
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
This will conflict with this one I guess:
status-im/status-desktop#16204
| @@ -317,24 +317,10 @@ func arrayContainsElement[T comparable](el T, arr []T) bool { | |||
| return false | |||
| } | |||
|
|
|||
| func arraysWithSameElements[T comparable](ar1 []T, ar2 []T, isEqual func(T, T) bool) bool { | |||
There was a problem hiding this comment.
@dlipicar what I had in mind with this function was to compare DisabledFromChainIDs and DisabledToChainIDs arrays, cause when client sends mainnet chain enabled only it sends for both arrays `[10, 42161], but now since they are converted to "enabled chains" we don't need it I guess.
There was a problem hiding this comment.
hmm not sure if you were planning to use that function in the future (you can re-introduce it then), it didn't make sense where it was used before since we had this check right before calling this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a couple of bugs, made some parts of the code tidier:
isEqualwasn't getting used here, so we were doing pointer comparison here. It was simplified to a==since we check the slices have a single element before anyway.