Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore_: refactor TestMessengerCollapsedComunityCategoriesSuite #5790

Merged

Conversation

igor-sirotin
Copy link
Collaborator

Initially i tried to figure out the culprit of TestE2eSendingReceivingProfilePicture and improve it.
But I couldn't make it faster yet, so for now just it's just a test refactoring 😐

Though I believe it's more readable and usable now 🙂

You can review by commits, if you wish to see the logic of changes.


Also moved TestMessengerCollapsedComunityCategoriesSuite to the right place.

@status-im-auto
Copy link
Member

status-im-auto commented Aug 30, 2024

Jenkins Builds

Click to see older builds (5)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 483df92 #1 2024-08-30 17:31:41 ~2 min tests 📄log
✔️ 483df92 #1 2024-08-30 17:31:48 ~2 min tests-rpc 📄log
✔️ 483df92 #1 2024-08-30 17:33:25 ~4 min linux 📦zip
✔️ 483df92 #1 2024-08-30 17:34:27 ~5 min ios 📦zip
✔️ 483df92 #1 2024-08-30 17:34:42 ~5 min android 📦aar
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7cb1034 #2 2024-08-30 20:20:42 ~1 min android 📦aar
✔️ 7cb1034 #2 2024-08-30 20:21:09 ~1 min linux 📦zip
✔️ 7cb1034 #2 2024-08-30 20:21:32 ~2 min tests-rpc 📄log
✔️ 7cb1034 #2 2024-08-30 20:23:44 ~4 min ios 📦zip
✔️ 7cb1034 #2 2024-08-30 20:52:00 ~32 min tests 📄log
✔️ b247bae #3 2024-09-03 11:01:27 ~1 min android 📦aar
✔️ b247bae #3 2024-09-03 11:02:04 ~2 min linux 📦zip
✔️ b247bae #3 2024-09-03 11:02:12 ~2 min tests-rpc 📄log
✔️ b247bae #3 2024-09-03 11:03:20 ~3 min ios 📦zip
✔️ b247bae #3 2024-09-03 11:32:50 ~32 min tests 📄log

protocol/messenger_builder_test.go Outdated Show resolved Hide resolved
protocol/messenger_identity_image_test.go Outdated Show resolved Hide resolved
@igor-sirotin igor-sirotin changed the title chore_: protocol test separate process chore_: refactor TestMessengerCollapsedComunityCategoriesSuite Sep 3, 2024
@igor-sirotin igor-sirotin requested a review from qfrank September 3, 2024 08:34
protocol/messenger_identity_image_test.go Outdated Show resolved Hide resolved
@igor-sirotin igor-sirotin merged commit 4083aae into develop Sep 3, 2024
11 checks passed
@igor-sirotin igor-sirotin deleted the fix/faster-TestE2eSendingReceivingProfilePicture branch September 3, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants