-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore_: refactor TestMessengerCollapsedComunityCategoriesSuite
#5790
Merged
igor-sirotin
merged 13 commits into
develop
from
fix/faster-TestE2eSendingReceivingProfilePicture
Sep 3, 2024
Merged
chore_: refactor TestMessengerCollapsedComunityCategoriesSuite
#5790
igor-sirotin
merged 13 commits into
develop
from
fix/faster-TestE2eSendingReceivingProfilePicture
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (5)
|
osmaczko
approved these changes
Sep 3, 2024
igor-sirotin
changed the title
chore_: protocol test separate process
chore_: refactor Sep 3, 2024
TestMessengerCollapsedComunityCategoriesSuite
qfrank
approved these changes
Sep 3, 2024
igor-sirotin
deleted the
fix/faster-TestE2eSendingReceivingProfilePicture
branch
September 3, 2024 11:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially i tried to figure out the culprit of
TestE2eSendingReceivingProfilePicture
and improve it.But I couldn't make it faster yet, so for now just it's just a test refactoring 😐
Though I believe it's more readable and usable now 🙂
You can review by commits, if you wish to see the logic of changes.
Also moved
TestMessengerCollapsedComunityCategoriesSuite
to the right place.