fix_: nightly test runs #5791
Merged
fix_: nightly test runs #5791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (25)
|
|
The first group of tests is still timing out, even with 5 minutes per run 🤔 |
|
Alright, no timeout panics now: |
osmaczko
approved these changes
Sep 3, 2024
|
|
||
| if [[ $HAS_PROTOCOL_PACKAGE == 'false' ]]; then | ||
| # This is the default single-line flow for testing all packages | ||
| # The `else` branch is temporary and will be removed once the `protocol` package runtime is optimized. |
There was a problem hiding this comment.
This will stay with us for a while :D
osmaczko
reviewed
Sep 3, 2024
igor-sirotin
force-pushed
the
fix/protocol-test-separate-process
branch
from
f209106 to
e8d67cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5401
#5731 made nightly tests extremely long.
go test ./protocol -test.count=20was run in a single process, so it was taking~30min * 20runs = 10hours.This is not acceptable. Quickly making the
protocolpackage run faster didn't seem possible, so I reverted the solution to spawn multiple processes.Yet, the result utilizes both approaches.
The
protocolpackage is now an exclusion, all other packages are run with defaultgo testbehaviour.Also fixed the coverage reporting for nightly tests
Test run for
count=20: https://ci.status.im/job/status-go/job/tests-nightly/366/NOTE: I currently included #5793 into this PR.
Will remove it when it's merged.