fix_: create/restore account error signal #6174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-sirotin
changed the title
Jenkins BuildsClick to see older builds (17)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6174 +/- ##
============================================
+ Coverage 13.90% 60.91% +47.00%
============================================
Files 817 832 +15
Lines 108265 109836 +1571
============================================
+ Hits 15054 66906 +51852
+ Misses 91290 35079 -56211
- Partials 1921 7851 +5930
Flags with carried forward coverage won't be shown. Click here to find out more.
|
igor-sirotin
force-pushed
the
fix/create-restore-account-error
branch
from
face655 to
c0bdb9b
Compare
osmaczko
approved these changes
Dec 5, 2024
igor-sirotin
force-pushed
the
fix/create-restore-account-error
branch
from
c0bdb9b to
f6e0f38
Compare
antdanchenko
approved these changes
Dec 6, 2024
igor-sirotin
force-pushed
the
fix/create-restore-account-error
branch
from
f6e0f38 to
f6001f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CreateAccountAndLoginandRestoreAccountAndLoginweren't publishingnode.loginsignal on error.Fixed it.
Replaced waiting for
node.readyto wait fornode.logininstead. And automatically check for error.This signal is published in a about the same time, but has advantages:
accountEnabled API logging during functional tests
Switched log level to
DEBUGcloses #6307