Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_: remove logging of rpc endpoint #6195

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

igor-sirotin
Copy link
Collaborator

@igor-sirotin igor-sirotin commented Dec 11, 2024

This could accidentally log secrets.

Fixes for release branches:

closes #6311

@igor-sirotin igor-sirotin added this to the 2.33.0 milestone Dec 11, 2024
@igor-sirotin igor-sirotin self-assigned this Dec 11, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Dec 11, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b1fc4c2 #1 2024-12-11 12:54:52 ~5 min macos 📦zip
✔️ b1fc4c2 #1 2024-12-11 12:55:55 ~6 min linux 📦zip
✔️ b1fc4c2 #1 2024-12-11 12:55:58 ~6 min android 📦aar
✔️ b1fc4c2 #1 2024-12-11 12:56:11 ~6 min ios 📦zip
✔️ b1fc4c2 #1 2024-12-11 12:56:17 ~6 min macos 📦zip
✔️ b1fc4c2 #1 2024-12-11 12:56:18 ~6 min windows 📦zip
✔️ b1fc4c2 #1 2024-12-11 12:56:59 ~7 min tests-rpc 📄log
✖️ b1fc4c2 #1 2024-12-11 13:20:21 ~30 min tests 📄log
✔️ b1fc4c2 #2 2024-12-14 18:56:15 ~30 min tests 📄log
✔️ b1fc4c2 #3 2024-12-14 21:47:09 ~29 min tests 📄log

@igor-sirotin igor-sirotin requested a review from a team December 13, 2024 18:29
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.44%. Comparing base (8b95c81) to head (b1fc4c2).
Report is 24 commits behind head on develop.

Files with missing lines Patch % Lines
protocol/ens/verifier.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6195      +/-   ##
===========================================
+ Coverage    61.36%   61.44%   +0.08%     
===========================================
  Files          832      832              
  Lines       109891   109891              
===========================================
+ Hits         67430    67523      +93     
+ Misses       34581    34524      -57     
+ Partials      7880     7844      -36     
Flag Coverage Δ
functional 19.62% <0.00%> (+0.08%) ⬆️
unit 60.11% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
protocol/ens/verifier.go 47.32% <0.00%> (ø)

... and 32 files with indirect coverage changes

@igor-sirotin igor-sirotin merged commit 6685032 into develop Dec 14, 2024
18 of 19 checks passed
@igor-sirotin igor-sirotin deleted the fix/remove-logging-rpc-endpoint branch December 14, 2024 23:00
Copy link

We require commits to follow the Conventional Commits, but with _ for non-breaking changes.
Please fix these commit messages:


@iurimatias iurimatias removed this from the 2.33.0 Beta milestone Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove logging of rpc endpoint
5 participants