chore(audit)_: Added fail conditions for malformed string ints #6289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (10)
|
osmaczko
approved these changes
Jan 29, 2025
saledjenic
approved these changes
Jan 30, 2025
Samyoul
force-pushed
the
chore/bit-int-err-check
branch
from
3544dba to
37cf705
Compare
Samyoul
force-pushed
the
chore/bit-int-err-check
branch
from
37cf705 to
5c73ebb
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (25.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #6289 +/- ##
===========================================
- Coverage 60.35% 60.29% -0.07%
===========================================
Files 845 846 +1
Lines 111357 111370 +13
===========================================
- Hits 67211 67147 -64
- Misses 36310 36394 +84
+ Partials 7836 7829 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves https://github.com/status-im/least-authority-audit/issues/13
In a few places we've not handled the fail condition for
big.Int.SetString(string), this PR adds the handling as per the audit feedback. See the above link for more details.