Add syncing notification to System Tab #21314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (8)
|
qfrank
reviewed
Sep 24, 2024
| @@ -28,7 +28,8 @@ | |||
|
|
|||
| ;; TODO: Replace with correct enum values once status-go implements them. | |||
| (def ^:const tx 66612) | |||
| (def ^:const system 66614) | |||
There was a problem hiding this comment.
Could you tell me why it was 66614 before? 🤔
There was a problem hiding this comment.
Seems like a temporary placeholder.
Replace with correct enum values once status-go implements them.
qfrank
approved these changes
Sep 24, 2024
ilmotta
approved these changes
Sep 24, 2024
|
@Parveshdhull Hi! |
Parveshdhull
force-pushed
the
syncing/notification-tab
branch
from
c72ea3c to
4e8abfa
Compare
Horupa-Olena
force-pushed
the
syncing/notification-tab
branch
from
4e8abfa to
1c45a7a
Compare
|
@Parveshdhull Thank you for your fix! All work is correct. I only have doubts about the fact that notifications disappear after confirming Pair and Sync and are not saved in the activity history. I couldn't find this point in Notion. |
100% of end-end tests have passedPassed tests (7)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletOneDevice:
|
|
@Parveshdhull We resolved this issue in the chat. Everything is fine, the PR is ready for merge. |
Parveshdhull
force-pushed
the
syncing/notification-tab
branch
from
1c45a7a to
fa794de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21288
Summary
Installation-related notification doesn't have their own tab. In the meeting with Alisher and QA, we agreed that for the time being show them in the System tab.
More information in the #21090 (comment) and in Issue description.
status: ready