Local docker environment setup #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for sending this @jpvanegasc! I haven't used Docker much, so I will need some time to test this. Do you happen to know if this will affect the GitHub Codespaces setup in any way? |
|
@stefmolin No worries, let me know if you have any questions or comments! As for the GitHub Codespaces, it shouldn't. I did a short smoke test and it seems that it still works fine. |
stefmolin
requested changes
Jul 21, 2024
There was a problem hiding this comment.
@jpvanegasc – this worked on my machine. I did notice a Docker warning, and I also think the Docker instructions could be reworked so it is easier to follow.
|
@stefmolin Made the changes you suggested; let me know if you have any more comments! |
stefmolin
reviewed
Jul 25, 2024
stefmolin
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes docker configuration files for setting up the project locally via docker-compose. Instructions on how to do so have also been added to the README.