Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to fix contrast issue #2

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
name: CI Pipeline Hanoi Towers

on:
push:
branches:
- master
pull_request:
types: [opened, synchronize, reopened]

Expand All @@ -18,7 +15,7 @@ jobs:
HANOI_FRONTEND_URL: ${{ vars.HANOI_FRONTEND_URL }}
HANOI_BACKEND_URL: ${{ vars.HANOI_BACKEND_URL }}
steps:
- name: Checkout
- name: Checkout Repository
uses: actions/checkout@v4.1.7
- name: Set up .env files
run: |
Expand Down Expand Up @@ -52,14 +49,19 @@ jobs:
- name: Install needed Chrome Version
run: npm install -g chromedriver@125
- name: Run Axe with set Chromedriver path
run: axe http://localhost:8080, http://localhost:8080/game, http://localhost:8080/cheat, http://localhost:8080/solver --chromedriver-path $(npm root -g)/chromedriver/bin/chromedriver --exit
continue-on-error: true
run: axe http://localhost:8080, http://localhost:8080/game, http://localhost:8080/cheat, http://localhost:8080/solver --chromedriver-path $(npm root -g)/chromedriver/bin/chromedriver --exit >> results
- name: Comment on PR
if: ${{ github.event_name == 'pull_request' }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
uses: JoseThen/comment-pr@v1.2.0
with:
file_path: './results'
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Fail if results file exists
run: |
pr_number=$(jq --raw-output .pull_request.number "$GITHUB_EVENT_PATH")
curl -s -H "Authorization: token $GITHUB_TOKEN" \
-X POST \
-d "{\"body\": \"Thank you for your contribution! We are reviewing your pull request.\"}" \
"https://api.github.com/repos/${{ github.repository }}/issues/$pr_number/comments"
if [ -f "./results" ]; then
echo "Results file with accessibility issues exists - Details in PR-comment. Failing the workflow."
exit 1
else
echo "No errors, be sure to still check manually for accessibility ;)"
fi
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@
*.iml
build
kotlin-js-store
results
4 changes: 2 additions & 2 deletions hanoi-frontend/src/jsMain/kotlin/lib/compose/modal/modal.kt
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ fun <Id> ModalLayer(
flexDirection(FlexDirection.Column)
height(100.vh)
backgroundColor(Color.black)
opacity(0.5)
opacity(1)
if(bottomUp) {
justifyContent(JustifyContent.FlexEnd)
}
Expand Down Expand Up @@ -148,4 +148,4 @@ fun <Id> Modal(
}
}
}
}
}
Loading