Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDP-1236] Fix SDP helm chart defaults and minimal-values #323

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

marwen-abid
Copy link
Collaborator

What

  • Small fixes when running this Chart using the minimal-values.yaml
  • Changed default background job processing to Scheduler instead of Kafka for an easier minimal setup
  • Fixed Anchor secrets that were being generated from the ConfigMap

Why

Propagate changes from this PR stellar/helm-charts#86

Checklist

PR Structure

  • This PR has a reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR title and description are clear enough for anyone to review it.
  • This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

  • No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
  • No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
  • No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
  • No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

  • This is not a breaking change.
  • This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

  • Does the deployment work after merging?

@marwen-abid marwen-abid requested a review from a team June 12, 2024 09:51
@marwen-abid marwen-abid self-assigned this Jun 12, 2024
@marwen-abid marwen-abid had a problem deploying to Receiver Registration - E2E Integration Tests June 12, 2024 09:51 — with GitHub Actions Failure
@marwen-abid marwen-abid temporarily deployed to Anchor Integration Tests June 12, 2024 09:51 — with GitHub Actions Inactive
Copy link
Collaborator

@marcelosalloum marcelosalloum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests June 13, 2024 01:40 — with GitHub Actions Inactive
@marwen-abid marwen-abid force-pushed the bugfix/SDP-1236-fix-sdp-helm-defaults branch from 204922d to a28efb2 Compare June 13, 2024 15:01
@marwen-abid marwen-abid temporarily deployed to Anchor Integration Tests June 13, 2024 15:01 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests June 13, 2024 15:01 — with GitHub Actions Inactive
@marwen-abid marwen-abid merged commit 7ba6f43 into develop Jun 13, 2024
13 checks passed
@marwen-abid marwen-abid deleted the bugfix/SDP-1236-fix-sdp-helm-defaults branch June 13, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants