Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a very annoying issue with
isort
on Windows -- formatter always added unnecessary line after imports.For example:
or
(added empty lines are redundant)
It looks like runner doesn't properly handle final
\r
on processing stdout:I came up with 2 solutions: the first one is this PR and the second one is simple:
I don't know which one is fine (maybe neither!), but the more complex one ended up as a PR because it edits multiple files