fix: tweak timeouts for aggregator and drop unnecessary check on buffering #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over last 2 weeks, 3 pieces did not make it to an aggregate. They were received and written into PieceStore, but their insertion did not put them into a Buffer to be reduced and aggregated. This seems a edge case and happened over a week ago. I suspect that this may be related to
batchItemFailures
usage having some extra configurations we are not using. Probably we would need to configure something else on (On-failure destination):Therefore, decided to just drop this, as we can rely on the
length !== 2
to fail anyway and retry after.Also tweaked some timeouts based on my observations of errors in the lambdas over the last 2 weeks based on timeouts