Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tweak timeouts for aggregator and drop unnecessary check on buffering #82

Conversation

vasco-santos
Copy link
Contributor

Over last 2 weeks, 3 pieces did not make it to an aggregate. They were received and written into PieceStore, but their insertion did not put them into a Buffer to be reduced and aggregated. This seems a edge case and happened over a week ago. I suspect that this may be related to batchItemFailures usage having some extra configurations we are not using. Probably we would need to configure something else on (On-failure destination):

image

Therefore, decided to just drop this, as we can rely on the length !== 2 to fail anyway and retry after.

Also tweaked some timeouts based on my observations of errors in the lambdas over the last 2 weeks based on timeouts

@seed-deploy seed-deploy bot temporarily deployed to pr82 November 29, 2023 09:51 Inactive
Copy link

seed-deploy bot commented Nov 29, 2023

View stack outputs

@vasco-santos vasco-santos merged commit c62f758 into main Nov 29, 2023
1 check passed
@vasco-santos vasco-santos deleted the fix/tweak-timeouts-for-aggregator-and-drop-unnecessary-check-on-buffering branch November 29, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants