Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support MFDA #239

Merged
merged 37 commits into from
Nov 16, 2023
Merged

support MFDA #239

merged 37 commits into from
Nov 16, 2023

Conversation

pesekon2
Copy link
Collaborator

@pesekon2 pesekon2 commented Oct 7, 2023

fix #148

@pesekon2 pesekon2 added the bug Something isn't working label Oct 7, 2023
@pesekon2 pesekon2 self-assigned this Oct 7, 2023
@pesekon2 pesekon2 marked this pull request as draft October 7, 2023 21:29
@pesekon2
Copy link
Collaborator Author

pesekon2 commented Oct 7, 2023

I am working on the MFDA support. The work progressed, but now it complains here in cell_runoff() that self.vol_runoff_pre is not defined. It is surely not defined but it is not defined even for D8, so it is not an MFDA-connected issue, but still should be solved.

@jerabekjak: Is it wrong that vol_runoff_pre is not defined? Should it be defined? Where? Or should another variable be used (vol_runoff? vol_runoff_rill?)?

@pesekon2
Copy link
Collaborator Author

@jerabekjak: Now, the computation with a configuration file posted below ends in MaxIterationExceeded. Is there an issue with the computation somewhere, or is it expected behaviour for the following configuration?

[data]
rainfall: tests/data/rainfall.txt
pickle: tests/data/destak.save

[time]
# maximum and initial time [sec]
maxdt: 30
# end time of simulations [min]
endtime: 60

[output]
outdir: tests/data/output
printtimes:

[logging]
level: DEBUG

[processes]
typecomp: rill
mfda: True

@pesekon2 pesekon2 marked this pull request as ready for review November 16, 2023 13:41
@pesekon2 pesekon2 requested a review from landam November 16, 2023 13:41
@pesekon2 pesekon2 merged commit 814a15a into master Nov 16, 2023
23 checks passed
@pesekon2 pesekon2 deleted the support_mfda branch November 16, 2023 13:53
@landam landam added this to the Version 2.0 milestone Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turning mfda on makes the test crash
2 participants