Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRASS: export temp data #284

Merged
merged 27 commits into from
Nov 16, 2023
Merged

GRASS: export temp data #284

merged 27 commits into from
Nov 16, 2023

Conversation

pesekon2
Copy link
Collaborator

@pesekon2 pesekon2 commented Nov 10, 2023 •
edited by landam
Loading

ArcGIS:

image

@pesekon2 pesekon2 self-assigned this Nov 10, 2023
@pesekon2 pesekon2 requested a review from landam November 13, 2023 06:41
landam
landam requested changes Nov 13, 2023
View reviewed changes
Copy link
Member

@landam landam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently GRASS produces:

tests/data/output/temp/
├── aoi_mask.tif
├── dem_filled.tif
├── dem_flowdir.tif
├── dem_slope_mask.tif
├── mat_boundary.asc
├── mat_boundary.asc.aux.xml
├── mat_boundary.prj
├── soilveg_aoi_b.tif
├── soilveg_aoi_k.tif
├── soilveg_aoi_n.tif
├── soilveg_aoi_pi.tif
├── soilveg_aoi_ppl.tif
├── soilveg_aoi_ret.tif
├── soilveg_aoi_s.tif
├── soilveg_aoi_tau.tif
├── soilveg_aoi_v.tif
├── soilveg_aoi_x.tif
├── soilveg_aoi_y.tif
├── stream.csv
└── stream_seg.tif

Still a lot of data layers compared to ArcGIS are missing (see PR description).

landam
landam requested changes Nov 13, 2023
View reviewed changes
tests/test_utils.py Outdated Show resolved Hide resolved
bin/base/__init__.py Show resolved Hide resolved
smoderp2d/providers/grass/data_preparation.py Outdated Show resolved Hide resolved
@landam
Copy link
Member

landam commented Nov 13, 2023

Some changes introduced in 7971ebe:

  • use pygrass module interface instead of kwargs
  • use writter to export raster
  • use writer to get file output path

@landam landam marked this pull request as draft November 13, 2023 12:23
@landam landam added this to the Version 2.0 milestone Nov 13, 2023
@landam
Copy link
Member

landam commented Nov 13, 2023 •
edited
Loading

Currently missing layers:

  • dem_aspect
  • dem_flowacc
  • dem_slope

@landam landam marked this pull request as ready for review November 14, 2023 07:49
@landam landam linked an issue Nov 14, 2023 that may be closed by this pull request
export data preparation outputs into target directory #228
Closed
@pesekon2 pesekon2 requested a review from landam November 15, 2023 11:23
landam
landam requested changes Nov 15, 2023
View reviewed changes
Copy link
Member

@landam landam left a comment •
edited by pesekon2
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • temp subgroup collapsed and unchecked
  • add control subgroup (collapsed and unchecked)
  • add control_points subgroup (collapsed and unchecked)
  • redo checkbox UI

@pesekon2 pesekon2 merged commit ab7dee9 into master Nov 16, 2023
@pesekon2 pesekon2 deleted the grass_export_temp_data branch November 16, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landam landam landam approved these changes

Assignees

@pesekon2 pesekon2

Labels
GRASS GIS QGIS
Projects
None yet
Milestone
Version 2.0
Development

Successfully merging this pull request may close these issues.

export data preparation outputs into target directory
2 participants
@pesekon2 @landam