Support subsurface #335
Merged
Support subsurface #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errors: the values are zero. and exfiltration is blank
the subsurface does not go to D8...
vol_runoff_rill vol_runoff_rill has to be here in order to cell_runoff in smoderp2d/core/flow.py works properly
|
Some tests need to be checked before merging. |
|
Some test fail on courant and number of iterations (see picture), other numbers are same... I'll check the failing tests and if this is the case for all of them I update the reference data.
|
|
Or also in water balance and 16 th place after floating point |
pesekon2
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement subsurface flow in to calculation core of the model.
note
subsoilrunoffbranch is too autdated