feat(DHT): NET-1436: Cut off connections to all application versions before v102.0.0

[juslesan]

Summary

Cut off connections to all application versions before v102.0.0

Changes

• Renamed handshake error UNSUPPORTED_PROTOCOL_VERSION -> UNSUPPORTED_VERSION. Version incompatibilities are handled similarly between protocol and application versions.

[linear]

NET-1436 Disconnect if incoming peer is <102.0.0

[teogeb]

Could we have two separate enums: UNSUPPORTED_PROTOCOL_VERSION (i.e. the current) and new UNSUPPORTED_APPLICATION_VERSION? It would give us more detailed information why a handshake fails.

[juslesan]

Could we have two separate enums: UNSUPPORTED_PROTOCOL_VERSION (i.e. the current) and new UNSUPPORTED_APPLICATION_VERSION? It would give us more detailed information why a handshake fails.

We could but older versions would not support the new failing UNSUPPORTED_APPLICATION_VERSION error. The behavior on how to handle unsupported version is the same for both cases so there is no requirement to add the new field to break backwards compatibility @teogeb

[teogeb]

Could we have two separate enums: UNSUPPORTED_PROTOCOL_VERSION (i.e. the current) and new UNSUPPORTED_APPLICATION_VERSION? It would give us more detailed information why a handshake fails.

We could but older versions would not support the new failing UNSUPPORTED_APPLICATION_VERSION error. The behavior on how to handle unsupported version is the same for both cases so there is no requirement to add the new field to break backwards compatibility @teogeb

What would happen in practice if a new client would send an error code 3 (the new UNSUPPORTED_APPLICATION_VERSION) which old nodes don't know about?

[juslesan]

Could we have two separate enums: UNSUPPORTED_PROTOCOL_VERSION (i.e. the current) and new UNSUPPORTED_APPLICATION_VERSION? It would give us more detailed information why a handshake fails.

We could but older versions would not support the new failing UNSUPPORTED_APPLICATION_VERSION error. The behavior on how to handle unsupported version is the same for both cases so there is no requirement to add the new field to break backwards compatibility @teogeb

What would happen in practice if a new client would send an error code 3 (the new UNSUPPORTED_APPLICATION_VERSION) which old nodes don't know about?

Don't know for sure but I would expect that the connection will eventually be cleaned up after a timeout. But there could be some undefined behavior that leads to problems