further trial of gh-action on windows

stschiff · Mar 7, 2024 · fb88767 · fb88767
1 parent 47fd3af
commit fb88767
Showing 1 changed file with 37 additions and 21 deletions.
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -1,9 +1,9 @@
 name: Release
-on:
+on: push
   # Trigger the workflow on the new 'v*' tag created
-  push:
-    tags:
-      - "v*"
+  # push:
+    # tags:
+    #   - "v*"
 
 jobs:
   create_release:
@@ -13,12 +13,12 @@ jobs:
       - name: Check out code
         uses: actions/checkout@v4
 
-      - name: Create Release
-        id: create_release
-        uses: ncipollo/release-action@v1
-        with:
-          name: Release ${{ github.ref_name }}
-          draft: true
+      # - name: Create Release
+      #   id: create_release
+      #   uses: ncipollo/release-action@v1
+      #   with:
+      #     name: Release ${{ github.ref_name }}
+      #     draft: true
 
   # build-on-centos:
   #   runs-on: ubuntu-latest
@@ -75,15 +75,31 @@ jobs:
 
     - name: Rename binaries (windows)
       if: ${{ matrix.os == 'windows-latest' }}
-      run: foreach ($tool in "genoStats", "pileupCaller", "vcf2eigenstrat") { Rename-Item "$env:USERPROFILE\AppData\Roaming\local\bin\$tool" "$tool-windows" }
+      # stack on windows installs into <Home>\AppData\Roaming\local\bin
+      # the default shell on Windows is powershell, so we use that
+      run: |
+        foreach ($tool in "genoStats", "pileupCaller", "vcf2eigenstrat") { Rename-Item "$env:USERPROFILE\AppData\Roaming\local\bin\$tool.exe" "$tool-windows.exe" }
 
-    - name: Upload Release Asset
-      id: upload-release-asset
-      uses: ncipollo/release-action@v1
-      with:
-        name: Release ${{ github.ref_name }}
-        draft: true
-        allowUpdates: true
-        artifactErrorsFailBuild: true
-        artifacts: "~/.local/bin/*"
-        artifactContentType: application/octet-stream
+    # - name: Upload Release Asset (not windows)
+    #   id: upload-release-asset
+    #   uses: ncipollo/release-action@v1
+    #   if: ${{ matrix.os != 'windows-latest' }}
+    #   with:
+    #     name: Release ${{ github.ref_name }}
+    #     draft: true
+    #     allowUpdates: true
+    #     artifactErrorsFailBuild: true
+    #     artifacts: "~/.local/bin/*"
+    #     artifactContentType: application/octet-stream
+
+    # - name: Upload Release Asset (windows)
+    #   id: upload-release-asset
+    #   uses: ncipollo/release-action@v1
+    #   if: ${{ matrix.os == 'windows-latest' }}
+    #   with:
+    #     name: Release ${{ github.ref_name }}
+    #     draft: true
+    #     allowUpdates: true
+    #     artifactErrorsFailBuild: true
+    #     artifacts: '%userprofile%\AppData\Roaming\local\bin\*.exe'
+    #     artifactContentType: application/octet-stream