Export bigwig files from split fragments file with tests #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addition of ExportGroupBW, CreateBWGroup and '%bcin%', to export bigwig file from split fragments file
Some changes from @timoast comments on the PR
SplitFragments inside the export function and check existing files
Add relative count normalization per group per 10k
Roxygen documentation and tests
I have an error passing the GroupNames via x
|
@timoast if you could help me to have rtracklayer installed to make the test pass would be very helpful. |
|
Thanks for reviving this PR @lldelisle, I have made some updates so the tests pass |
|
Why don't you want rtracklayer to be a requirement? I think it is better if this part is also tested in the CI, no? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #1383