Added approved valentines interface in admin panel for read only access #282
Conversation
✅ Deploy Preview for stuyepsilon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Instead of duplicating the bulk of ValentineDisplay to make ApprovedValentineDisplay, these changes should be made through a read-only mode (perhaps implied by refresh being undefined) on ValentineDisplay. I cannot in good conscience merge duplicated code like this.
There was a problem hiding this comment.
Is this duplicating the lion's share of ValentinesDisplay code?
There was a problem hiding this comment.
I do not consider it acceptable to merge this duplicated code (with unnecessary functionality like fetching user identities to boot!).
|
I will handle this matter this afternoon |
| @@ -114,6 +121,10 @@ const AdminRouter = () => { | |||
| <Route path="/announcements" Component={Announcements} /> | |||
| <Route path="/rooms" Component={Rooms} /> | |||
| <Route path="/valentines" Component={Valentines} /> | |||
| <Route | |||
| path="/approved-valentines" | |||
There was a problem hiding this comment.
TODO for someone in the future: make this /valentines/approved or something like that (two tabs on the admin panel is a bit wasteful)
| @@ -114,6 +121,10 @@ const AdminRouter = () => { | |||
| <Route path="/announcements" Component={Announcements} /> | |||
| <Route path="/rooms" Component={Rooms} /> | |||
| <Route path="/valentines" Component={Valentines} /> | |||
| <Route | |||
| path="/approved-valentines" | |||
There was a problem hiding this comment.
TODO for someone in the future: make this /valentines/approved or something like that (two tabs on the admin panel is a bit wasteful)
No description provided.