Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Non-dimensionalization to translation velocity #2417

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

rois1995
Copy link
Contributor

Proposed Changes

Problem: When a marker is translating, the translation velocity is not adimensionalized. An adimensional unsteady simulation will diverge after the first iteration.
Fix: add non-dimensionalization of translation velocity in Mesh solver.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@rois1995 rois1995 changed the title Fic Non-dimensionalization to translation velocity Fix Non-dimensionalization to translation velocity Jan 13, 2025
@rois1995
Copy link
Contributor Author

Here the problem and the fix are shown:

NACA0012 moving downwards with a certain velocity.

Black line = starting profile
Red line = after one iteration and with dimensional simulation
Blue line = after one iteration and with non-dimensional simulation pre-fix
Green dots = after one iteration and with non-dimensional simulation post-fix

Screen

@rois1995 rois1995 merged commit 2b6d97a into develop Jan 13, 2025
35 of 36 checks passed
@rois1995 rois1995 deleted the fix_TranslVel branch January 13, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants