Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructured the reading of the high order grids for the FEM solver #2440

Merged
merged 16 commits into from
Feb 6, 2025

Conversation

vdweide
Copy link
Contributor

@vdweide vdweide commented Feb 5, 2025

Proposed Changes

Adapted the reading of the higher grids, such that it now uses the various meshreader classes. There is some additional functionality, namely that it is now possible to use rectangular and box grids with the higher order FEM solver, but it is mainly meant to make the reading more consistent with the code infrastructure. For this reason additional base classes have been introduced for the reading of CGNS and SU2ASCII files.

Related Work

This is the first of a couple of PRs to clean up the code for the DG-FEM solver. It does not add any functionality nor it fixes any bugs.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@vdweide vdweide merged commit 5db56f9 into develop Feb 6, 2025
35 checks passed
@vdweide vdweide deleted the feature_hom_read_mesh branch February 6, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants